On Thu, Aug 24, 2006 at 08:06:26PM +0100, Daniel P. Berrange wrote: > On Thu, Aug 24, 2006 at 09:00:58PM +0200, Karel Zak wrote: > > On Thu, Aug 24, 2006 at 02:07:51PM +0100, Daniel P. Berrange wrote: > > > Quite a critical bit of the libvirt code is that which converts between > > > SEXPR and XML, and vica-verca. I've broken this code several times when > > > > This is exactly reason why I've created unit tests stuff in libvirt > > ;-) It's important create unit tests for all things like parsers, > > convertors, ... > > > > > RCS file: tests/sexpr2xml-fv.sexpr > > > diff -N tests/sexpr2xml-fv.sexpr > > > *** /dev/null 1 Jan 1970 00:00:00 -0000 > > > --- tests/sexpr2xml-fv.sexpr 24 Aug 2006 13:57:37 -0000 > > > > Maybe you can create some subdirectory in tests/ for data otherwise > > it will be crowded. > > Yeah, probably a good idea - particularly as I'm about to create 30 > or more test data files for 'virsh' too :-) Sounds good, but use specialized subdirs, thanks :-) Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/