On Thu, Aug 10, 2006 at 11:00:01PM +0100, Daniel P. Berrange wrote:
> On Thu, Aug 10, 2006 at 08:31:28AM -0400, Daniel Veillard wrote:
> > Agreed. And the changes suggested should not affect the very simple
> > case which worked, except for the 'ioemu:' device prefix. We can just
> > discard it when reading the XML and add it when
> > just discard it except that before xen-3.0.3 this will need to be added
> > back, and post xen-3.0.3 this should be allowed by xend
>
> Ok attached an updated version of the patch which the various changes discussed
> in this thread - in particular the addition of a 'device' attribute to the <disk>
> element accepting 'disk', 'floppy', or 'cdrom' and defaulting to 'disk' if it
> is omitted. Best illustrated by example XML dump:
Looks just fine to me.
> Note that the ioemu: prefix is now not exposed in the XML - we add it back
> on when creating the SEXPR, or strip it when parsing the SEXPR. Until Xen
> 3.0.3 when 'device=cdrom' the only valid target dev is 'hdc', after 3.0.3
> this can be relaxed to allow hda->hdd
Since we can't detect xend version, that's a good way to proceed,
thanks !
Daniel
--
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard | virtualization library http://libvirt.org/
veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/