On Sat, Aug 05, 2006 at 01:27:43AM +0100, Daniel P. Berrange wrote: > I added 3 more convenience macros: > > VIR_NODEINFO_MAXCPUS(nodeinfo) > VIR_CPU_MAPLEN(cpu) > VIR_CPU_FULL_MAPLEN(vcpu, cpu) good, yes > To hide the maths from developers. > > I also bug-fixed the pin cpu method which mistakenly checked for vcpu < 1 > instead of vcpu < 0 when validating args. good catch ! > See atached patch for these changes Looks sane to me, please commit :-) > > One more: > > > > - expose the new APIs via virsh. Michael originally suggsted pretty much > > following the style of 'xm vcpu-pin' and 'vcpu-list'. Seems like a fairly > > reasonable pattern to follow. > > See the attached patch which adds these commands. eg: very cool :-), Yay ! Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/