On Mon, Jun 12, 2006 at 06:52:57PM -0400, Daniel Veillard wrote: > On Mon, Jun 12, 2006 at 11:19:00PM +0100, Daniel P. Berrange wrote: > > virGetVersion: > > > > - Hardcodes support for Xen HV. No virConnectPtr handle, so > > how would we call out to driver backends ? > > > > yes that's an API bug :-\ , I'm afraid that mean I will have to make a > release breaking compatibility, annoying, better do that as soon as possible. Actually no :-) no need to change the function signature I think: http://libvirt.org/html/libvirt-libvirt.html#virGetVersion Provides two information back, @libVer is the version of the library while @typeVer will be the version of the hypervisor type @type against which the library was compiled. If @type is NULL, "Xen" is assumed, if @type is unknown or not availble, an error code will be returned and @typeVer will be 0. this is a static compile time check. What we need is to provide a version info from the driver, if possible provided in the source, but that should not require a change of the User API. On the other hand adding a version field from struct _virDriver make sense, but it's not impacting user code at all, I will do that. Daniel -- Daniel Veillard | Red Hat http://redhat.com/ veillard@xxxxxxxxxx | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/