Vicente, Firstly, thanks a lot for the contribution! There are a few things though, that I'd like to understand better and/or have to be fixed before pushing the patches. Please, see the comments below. On Thu, Aug 29, 2019 at 12:46 AM Vicente Chaves de Melo <vchaves@xxxxxxxxx> wrote: > > --- > data/os/netbsd.org/netbsd-8.1.xml.in | 64 ++++++++++++++++++++++ > .../netbsd8.1/NetBSD-8.1-amd64-boot-com.iso.txt | 33 +++++++++++ > .../netbsd/netbsd8.1/NetBSD-8.1-amd64-boot.iso.txt | 33 +++++++++++ > .../netbsd/netbsd8.1/NetBSD-8.1-amd64.iso.txt | 33 +++++++++++ > .../netbsd8.1/NetBSD-8.1-i386-boot-com.iso.txt | 33 +++++++++++ > .../netbsd/netbsd8.1/NetBSD-8.1-i386-boot.iso.txt | 33 +++++++++++ > .../netbsd/netbsd8.1/NetBSD-8.1-i386.iso.txt | 33 +++++++++++ > 7 files changed, 262 insertions(+) > create mode 100644 data/os/netbsd.org/netbsd-8.1.xml.in > create mode 100644 tests/isodata/netbsd/netbsd8.1/NetBSD-8.1-amd64-boot-com.iso.txt > create mode 100644 tests/isodata/netbsd/netbsd8.1/NetBSD-8.1-amd64-boot.iso.txt > create mode 100644 tests/isodata/netbsd/netbsd8.1/NetBSD-8.1-amd64.iso.txt > create mode 100644 tests/isodata/netbsd/netbsd8.1/NetBSD-8.1-i386-boot-com.iso.txt > create mode 100644 tests/isodata/netbsd/netbsd8.1/NetBSD-8.1-i386-boot.iso.txt > create mode 100644 tests/isodata/netbsd/netbsd8.1/NetBSD-8.1-i386.iso.txt > > diff --git a/data/os/netbsd.org/netbsd-8.1.xml.in b/data/os/netbsd.org/netbsd-8.1.xml.in > new file mode 100644 > index 0000000..cd81e68 > --- /dev/null > +++ b/data/os/netbsd.org/netbsd-8.1.xml.in > @@ -0,0 +1,64 @@ > +<libosinfo version="0.0.1"> > + > + <os id="http://netbsd.org/netbsd/8.1";> > + <short-id>netbsd8.1</short-id> > + <_name>NetBSD 8.1</_name> > + <version>8.1</version> > + <_vendor>NetBSD Project</_vendor> > + <family>netbsd</family> > + <distro>netbsd</distro> > + <upgrades id="http://netbsd.org/netbsd/8.1"/> > + <derives-from id="http://netbsd.org/netbsd/8.1"/> 8.1 should upgrade & derive-from 8.0, not 8.1 Btw, did 8.0 reach its EoL? If so, would be worth updating that entry as well (together with older entries, if possible). [snip] > + <media arch="x86_64"> > + <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-8.1/amd64/installation/cdrom/boot.iso</url> > + <iso> > + <system-id>NetBSD</system-id> > + <volume-id>NETBSD_81</volume-id> > + <volume-size>233302016</volume-size> > + </iso> > + </media> > + <media arch="x86_64"> > + <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-8.1/amd64/installation/cdrom/boot-com.iso</url> > + <iso> > + <system-id>NetBSD</system-id> > + <volume-id>NETBSD_81</volume-id> > + <volume-size>233302016</volume-size> > + </iso> > + </media> I can see that both boot.iso and boot-com.iso have the very same volume-id, system-id, and even volume-size. What's the difference between these medias, if any? Also, would be worth to add a "netinst" variant for those, in case they're supposed to be used as net installers. [snip] > + <media arch="i686"> > + <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-8.1/i386/installation/cdrom/boot.iso</url> > + <iso> > + <system-id>NetBSD</system-id> > + <volume-id>NETBSD_81</volume-id> > + <volume-size>215072768</volume-size> > + </iso> > + </media> > + <media arch="i686"> > + <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-8.1/i386/installation/cdrom/boot-com.iso</url> > + <iso> > + <system-id>NetBSD</system-id> > + <volume-id>NETBSD_81</volume-id> > + <volume-size>215072768</volume-size> > + </iso> > + </media> Same comment as above. > + </os> > +</libosinfo> [snip] Best Regards, -- Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
