On 7/16/19 10:41 AM, Fabiano Fidêncio wrote: > As osinfo_media_create_from_location_with_flags_async() can handle > non-local cases, they'd end up relying on GVFS under the hood, which > would cause those APIs to not work when called from an app running as > root. > > In order to avoid this situation, let's rely on libsoup for these cases. > > https://gitlab.com/libosinfo/libosinfo/issues/30 > > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> > --- > configure.ac | 1 + > libosinfo.spec.in | 1 + > osinfo/Makefile.am | 7 ++++- > osinfo/osinfo_media.c | 60 +++++++++++++++++++++++++++--------- > osinfo/osinfo_util_private.c | 35 +++++++++++++++++++++ > osinfo/osinfo_util_private.h | 28 +++++++++++++++++ > 6 files changed, 116 insertions(+), 16 deletions(-) > create mode 100644 osinfo/osinfo_util_private.c > create mode 100644 osinfo/osinfo_util_private.h osinfo_util_private.c needs #include <config.h> to pass syntax-check. But otherwise this series looks good to me with the caveats I mentioned in the osinfo-db-tools series Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
