Re: [osinfo-db-tools PATCH v3 0/9] Drop GVFS dependency in favour of libsoup (+ some cleanups)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/11/19 3:34 PM, Fabiano Fidêncio wrote:
> Let's rely on libsoup in order to to http://, https://, and ftp://
> requests.
> 
> By doing this, GVFS (more specifically, gvfs-http) won't be dragged as
> a dependency, which caused errors for running osinfo-db-import as root
> (as GVFS relies on being run in the user's session).
> 
> https://gitlab.com/libosinfo/libosinfo/issues/30
> 
> The cleanups are basically in order to use g_clear_*() functions.
> 

With the caveats that my glib is weak, I've never coded against libsoup,
and I don't have any real work flow around osinfo-db-tools usage, I
didn't notice anything wrong with this series, so:

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

- Cole

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux