When dealing with Fedora/CentOS net-install ISOs, we may reach the situation where the command-line template will generate the command-line adding a "inst.repo=" but the installation URL is not present. The easiest way to deal with this is checking whether an installation URL is present and only adding "inst.repo=" if that's the case. https://gitlab.com/libosinfo/osinfo-db/issues/29 Cole, I've tested this using the following command-lines: fidencio@laerte ~/src/upstream/virt-manager $ ./virt-install --location ~/Downloads/Fedora-Workstation-netinst-x86_64-30-1.2.iso --unattended --debug --dry-run ... <os> <type arch="x86_64" machine="q35">hvm</type> <kernel>/home/fidencio/.cache/virt-manager/boot/virtinst-78wrkio3-vmlinuz</kernel> <initrd>/home/fidencio/.cache/virt-manager/boot/virtinst-1fijdwll-initrd.img</initrd> <cmdline>ks=file:/fedora.ks</cmdline> </os> ... fidencio@laerte ~/src/upstream/virt-manager $ ./virt-install --install fedora30 --unattended --debug --dry-run ... <os> <type arch="x86_64" machine="q35">hvm</type> <kernel>/home/fidencio/.cache/virt-manager/boot/virtinst-yjqucpkl-vmlinuz</kernel> <initrd>/home/fidencio/.cache/virt-manager/boot/virtinst-s1_hgwl6-initrd.img</initrd> <cmdline>ks=file:/fedora.ks inst.repo=https://download.fedoraproject.org/pub/fedora/linux/releases/30/Workstation/x86_64/os</cmdline> </os> ... Fabiano Fidêncio (2): install-script,fedora: Only add install-source if there's an install URL install-script,rhel: Only add install-source if there's an install URL .../fedoraproject.org/fedora-kickstart-desktop.xml.in | 7 +++++-- .../fedoraproject.org/fedora-kickstart-jeos.xml.in | 7 +++++-- .../redhat.com/rhel-kickstart-desktop.xml.in | 7 +++++-- data/install-script/redhat.com/rhel-kickstart-jeos.xml.in | 7 +++++-- 4 files changed, 20 insertions(+), 8 deletions(-) -- 2.21.0 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
