On Mon, Jul 01, 2019 at 07:51:52PM -0400, Cole Robinson wrote: > On 6/27/19 8:56 AM, Fabiano Fidêncio wrote: > > Let's rely on libsoup in order to to http://, https://, and ftp:// > > requests. > > > > By doing this, GVFS (more specifically, gvfs-http) won't be dragged as > > a dependency, which caused errors for apps running as root (as GVFS > > relies on being run in the user's session). > > > > https://gitlab.com/libosinfo/libosinfo/issues/30 > > > > Fabiano Fidêncio (7): > > media: Fix indentation in create_from_location_asunc_data_free() > > tree: Remove not used Tree from _CreateFromLocationAsyncData struct > > media: Improve on_location_read error message readability > > media: Use GInpuStream directly in on_location_read() > > media: Use libsoup for http://, https://, and ftp:// requests > > tree: Use libsoup for http://, https://, and ftp:// requests > > spec: Drop gvfs dependency > > > > configure.ac | 5 +- > > libosinfo.spec.in | 2 +- > > osinfo/Makefile.am | 5 +- > > osinfo/libosinfo.syms | 2 + > > osinfo/osinfo_media.c | 86 ++++++++++++++++++++++++--------- > > osinfo/osinfo_tree.c | 108 +++++++++++++++++++++++++++++------------- > > osinfo/osinfo_tree.h | 11 +++++ > > 7 files changed, 159 insertions(+), 60 deletions(-) > > > > Does libsoup actually handle FTP? Googling doesn't turn up any obvious > hits. That said I don't know if GVFS handles it either. With the > virt-manager test suite and libosinfo git master, I see: > > $ ./setup.py test_urls --debug --force-libosinfo --only fedora-ftp > ... > DEBUG Error creating libosinfo tree object for > location=ftp://ftp.tu-chemnitz.de/pub/linux/fedora/linux/releases/30/Server/x86_64/os/ > : g-io-error-quark: Failed to load .treeinfo|treeinfo file: The > specified location is not mounted (16) > ... > > So it doesn't seem to work anyway. But with your patch series it hangs > until it hits a two minute socket timeout. Which makes me wonder if > libsoup is trying to talk http to an ftp URL. > > FWIW I don't think that should be an argument for keeping a gvfs > dependency. It's getting hard to even find public ftp mirrors these days Yes, I think we should be explicit that FTP is not supported. There's no compelling reason to use FTP over HTTP(S) these days, even the kernel has disabled it https://www.kernel.org/shutting-down-ftp-services.html Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
