Re: [osinfo-db-tools PATCH 0/3] Fix coverity/clang issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/20/19 8:39 AM, Fabiano Fidêncio wrote:
> This series fixes 3 issues found by either coverity or clang.
> The issues are:
> - FORWARD_NULL, due to the possibility of calling unlink(NULL) in the
>   osinfo-db-import code;
> - DEADCODE, due to err being declared, instantiated but never used in the
>   osinfo-db-export code;
> - A memory leak of memory pointed to by "files";
> 
> Fabiano Fidêncio (3):
>   import: Don't call unlink(NULL)
>   export: Remove unused variable
>   validate: Don't leak "files"
> 
>  tools/osinfo-db-export.c   | 3 ---
>  tools/osinfo-db-import.c   | 2 +-
>  tools/osinfo-db-validate.c | 1 +
>  3 files changed, 2 insertions(+), 4 deletions(-)
> 

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

- Cole

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux