Sure, thanks for the review! Feel free to amend the proposed changes. Acked-by: Felipe Borges <feborges@xxxxxxxxxx> On Thu, May 2, 2019 at 9:47 AM Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > > On Tue, 2019-04-30 at 17:51 +0200, Felipe Borges wrote: > > Signed-off-by: Felipe Borges <feborges@xxxxxxxxxx> > > --- > > .../os/fedoraproject.org/silverblue-30.xml.in | 58 > > +++++++++++++++++++ > > ...ra-Silverblue-ostree-x86_64-30-1.2.iso.txt | 29 ++++++++++ > > 2 files changed, 87 insertions(+) > > create mode 100644 data/os/fedoraproject.org/silverblue-30.xml.in > > create mode 100644 tests/isodata/fedora/silverblue30/Fedora- > > Silverblue-ostree-x86_64-30-1.2.iso.txt > > > > diff --git a/data/os/fedoraproject.org/silverblue-30.xml.in > > b/data/os/fedoraproject.org/silverblue-30.xml.in > > new file mode 100644 > > index 0000000..5589b9c > > --- /dev/null > > +++ b/data/os/fedoraproject.org/silverblue-30.xml.in > > @@ -0,0 +1,58 @@ > > +<libosinfo version="0.0.1"> > > +<!-- Licensed under the GNU General Public License version 2 or > > later. > > + See http://www.gnu.org/licenses/ for a copy of the license text > > --> > > + <os id="http://fedoraproject.org/silverblue/30";> > > + <short-id>silverblue30</short-id> > > + <_name>Fedora Silverblue 30</_name> > > + <version>30</version> > > + <_vendor>Fedora Project</_vendor> > > + <family>linux</family> > > + <distro>fedora</distro> > > + <upgrades id="http://fedoraproject.org/silverblue/29"/> > > + <derives-from id="http://fedoraproject.org/silverblue/29"/> > > + > > + <release-date>2019-04-30</release-date> > > + > > + <media arch="x86_64"> > > + <url> > > https://download.fedoraproject.org/pub/fedora/linux/releases/30/Silverblue/x86_64/iso/Fedora-Silverblue-ostree-x86_64-30-1.2.iso</url > > > > > + <iso> > > + <volume-id>Fedora-SB-ostree-x86_64-30</volume-id> > > + <system-id>LINUX</system-id> > > Fedora Silverblue has removed the "System id:" field from its media, so > the line above must be removed as well. > > > + </iso> > > + <kernel>isolinux/vmlinuz</kernel> > > + <initrd>isolinux/initrd.img</initrd> > > + </media> > > + > > + <tree arch="x86_64"> > > + <url> > > https://download.fedoraproject.org/pub/fedora/linux/releases/30/Silverblue/x86_64/os</url > > > > > + <treeinfo> > > + <family>Fedora</family> > > + <variant>Silverblue</variant> > > + <version>30</version> > > + <arch>x86_64</arch> > > + </treeinfo> > > + </tree> > > + > > + <resources arch="all"> > > + <minimum> > > + <n-cpus>1</n-cpus> > > + <cpu>1000000000</cpu> > > + <ram>1073741824</ram> > > + <storage>10737418240</storage> > > + </minimum> > > + > > + <recommended> > > + <ram>2147483648</ram> > > + <storage>21474836480</storage> > > + </recommended> > > + > > + <network-install> > > + <ram>5368709120</ram> > > + </network-install> > > + </resources> > > + > > + <installer> > > + <script id=' > > http://fedoraproject.org/silverblue/kickstart/desktop'/> > > + </installer> > > + </os> > > +</libosinfo> > > diff --git a/tests/isodata/fedora/silverblue30/Fedora-Silverblue- > > ostree-x86_64-30-1.2.iso.txt > > b/tests/isodata/fedora/silverblue30/Fedora-Silverblue-ostree-x86_64- > > 30-1.2.iso.txt > > new file mode 100644 > > index 0000000..62bfc41 > > --- /dev/null > > +++ b/tests/isodata/fedora/silverblue30/Fedora-Silverblue-ostree- > > x86_64-30-1.2.iso.txt > > @@ -0,0 +1,29 @@ > > +CD-ROM is in ISO 9660 format > > +System id: > > +Volume id: Fedora-SB-ostree-x86_64-30 > > +Volume set id: > > +Publisher id: > > +Data preparer id: XORRISO-1.5.0 2018.09.15.133001, LIBISOBURN-1.5.0, > > LIBISOFS-1.5.0, LIBBURN-1.5.0 > > +Application id: > > +Copyright File id: > > +Abstract File id: > > +Bibliographic File id: > > +Volume set size is: 1 > > +Volume set sequence number is: 1 > > +Logical block size is: 2048 > > +Volume size is: 1066864 > > +El Torito VD version 1 found, boot catalog is in sector 40 > > +Joliet with UCS level 3 found > > +Rock Ridge signatures version 1 found > > +Eltorito validation header: > > + Hid 1 > > + Arch 0 (x86) > > + ID '' > > + Key 55 AA > > + Eltorito defaultboot header: > > + Bootid 88 (bootable) > > + Boot media 0 (No Emulation Boot) > > + Load segment 0 > > + Sys type 0 > > + Nsect 4 > > + Bootoff 13A4 5028 > > > As the other patch, I can fix this before pushing, but I'd like to have > your ACK in the proposed changes. > > Best Regards, > -- > Fabiano Fidêncio > > _______________________________________________ > Libosinfo mailing list > Libosinfo@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libosinfo _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
