Re: [osinfo-db-tools PATCH] test_osinfo_db_path: Don't fail if OSINFO_*_DIR are set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 30, 2019 at 11:54 AM Pino Toscano <ptoscano@xxxxxxxxxx> wrote:
>
> On Tuesday, 30 April 2019 11:46:05 CEST Fabiano Fidêncio wrote:
> > In case OSINFO_{SYSTEM,DATA,USER}_DIR are set, let's just use those
> > values in test_osinfo_db_path.py instead of the pre-defined ones.
> >
> > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> > ---
>
> Wouldn't it better to unset the variables in the test, to make it more
> stable w.r.t. the environment it runs in?

Makes sense. Just submitted a v2.

Best Regards,
-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux