This patchset introduces a bunch of functional tests for osinfo-db-tools, covering all the tools and their command-lines. Daniel, what do you think we should do with regards to adding the python dependencies to the spec file? Just add them as BuildRequires? This series has not been tested on EL7 at all. So, no python2 support is provided unless someone has a strong opinion on adding it (then I'll find out what has to be done in order to properly support it). Also, we'll need to patch libvirt-jenkins-ci in order to update the deps and ensure that make check is ran for osinfo-db-tools, but it's going to be done after we have this series reviewed. https://gitlab.com/libosinfo/osinfo-db-tools/issues/2 Fabiano Fidêncio (7): makefile: Add needed machinery for tests tests: Add util.py tests: Add tests data tests: Add osinfo-db-path tests tests: Add osinfo-db-validate tests tests: Add osinfo-db-{export,import} tests spec: Add %check target .gitignore | 3 + Makefile.am | 2 +- configure.ac | 1 + osinfo-db-tools.spec.in | 7 + tests/Makefile.am | 26 + tests/data/license | 2 + .../os/fedoraproject.org/fedora-rawhide.xml | 74 ++ tests/data/negative/schema/osinfo.rng | 899 ++++++++++++++++++ .../positive/datamap/x.org/x11-keyboard.xml | 150 +++ .../positive/device/ibm.com/ps2-keyboard.xml | 22 + .../silverblue-kickstart-desktop.xml | 116 +++ .../os/fedoraproject.org/fedora-rawhide.xml | 74 ++ .../platform/linux-kvm.org/qemu-kvm-1.2.0.xml | 29 + tests/data/positive/schema/osinfo.rng | 899 ++++++++++++++++++ tests/test_osinfo_db_export_import.py | 263 +++++ tests/test_osinfo_db_path.py | 70 ++ tests/test_osinfo_db_validate.py | 76 ++ tests/util.py | 146 +++ 18 files changed, 2858 insertions(+), 1 deletion(-) create mode 100644 tests/Makefile.am create mode 100644 tests/data/license create mode 100644 tests/data/negative/os/fedoraproject.org/fedora-rawhide.xml create mode 100644 tests/data/negative/schema/osinfo.rng create mode 100644 tests/data/positive/datamap/x.org/x11-keyboard.xml create mode 100644 tests/data/positive/device/ibm.com/ps2-keyboard.xml create mode 100644 tests/data/positive/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml create mode 100644 tests/data/positive/os/fedoraproject.org/fedora-rawhide.xml create mode 100644 tests/data/positive/platform/linux-kvm.org/qemu-kvm-1.2.0.xml create mode 100644 tests/data/positive/schema/osinfo.rng create mode 100755 tests/test_osinfo_db_export_import.py create mode 100755 tests/test_osinfo_db_path.py create mode 100755 tests/test_osinfo_db_validate.py create mode 100644 tests/util.py -- 2.21.0 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo