Re: [libosinfo PATCH] media: Fix usage of application id

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/1/19 4:45 PM, Fabiano Fidêncio wrote:
> Christophe Fergeau pointed this issue out during the review of 6d789033e
> and, even though, the bogus code ended up merged (sorry, mea culpa
> here!).
> 
> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
>  osinfo/osinfo_media.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/osinfo/osinfo_media.c b/osinfo/osinfo_media.c
> index b16fcf6..4f86c2b 100644
> --- a/osinfo/osinfo_media.c
> +++ b/osinfo/osinfo_media.c
> @@ -830,10 +830,10 @@ create_from_location_async_data(CreateFromLocationAsyncData *data)
>          osinfo_entity_set_param(OSINFO_ENTITY(media),
>                                  OSINFO_MEDIA_PROP_PUBLISHER_ID,
>                                  data->publisher);
> -    if (!is_str_empty(data->pvd.application))
> +    if (!is_str_empty(data->application))
>          osinfo_entity_set_param(OSINFO_ENTITY(media),
>                                  OSINFO_MEDIA_PROP_APPLICATION_ID,
> -                                data->pvd.application);
> +                                data->application);
>  
>      index = (G_BYTE_ORDER == G_LITTLE_ENDIAN) ? 0 : 1;
>      vol_size = ((gint64) data->pvd.volume_space_size[index]) *
> 

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

- Cole

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux