On 4/2/19 6:18 AM, Fabiano Fidêncio wrote: > This series has been written considering: > - https://www.redhat.com/archives/libosinfo/2019-February/msg00247.html > > Let's assume that trees and medias set with architecture "all" will be > treated as fallback, always. > > NOTE: In the v3 a different approach has been taken and there's no > explicit check comparing architectures. The reason for this is that > create_media_from_location() will always create a media with NULL arch, > which would simply break the check. :-( > For now, let's just leave arch out of the game, as it was before this > series, and just check the arch of our DB entries in order to leave all > the entries with "all" arch to be evaluated later. > > https://gitlab.com/libosinfo/libosinfo/issues/20 > > Fabiano Fidêncio (6): > db: Rename tree to treeinfo in guess_os_from_tree() > db: Rename os_* to os_treeinfo_* in guess_os_from_tree() > db: Deal with "all" tree architectures > test-db: Add test for guessing tree from OS > db: Deal with "all" media architecture > test-db: Add test to cover identifying a media with "unknown" arch > > osinfo/osinfo_db.c | 178 +++++++++++------- > .../dbdata/os/libosinfo.org/test-db-media.xml | 13 ++ > .../dbdata/os/libosinfo.org/test-db-tree.xml | 26 +++ > tests/test-db.c | 80 ++++++++ > 4 files changed, 233 insertions(+), 64 deletions(-) > create mode 100644 tests/dbdata/os/libosinfo.org/test-db-tree.xml > Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> I ran my full test suite now and no regressions found. Thanks, Cole _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
