On 3/26/19 8:05 AM, Fabiano Fidêncio wrote: > osinfo-db schema allows that, but libosinfo never really had an API to > support it. > > https://gitlab.com/libosinfo/libosinfo/issues/16 > > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> > --- > osinfo/osinfo_loader.c | 17 ++++++++- > osinfo/osinfo_os.c | 2 ++ > osinfo/osinfo_tree.c | 70 +++++++++++++++++++++++++++++++++++- > osinfo/osinfo_tree.h | 2 ++ > osinfo/osinfo_tree_private.h | 29 +++++++++++++++ > 5 files changed, 118 insertions(+), 2 deletions(-) > create mode 100644 osinfo/osinfo_tree_private.h > I needed this to make get_os_variants appear in python bindings: diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms index aa8e6d7..7ef878e 100644 --- a/osinfo/libosinfo.syms +++ b/osinfo/libosinfo.syms @@ -572,6 +572,8 @@ LIBOSINFO_1.5.0 { global: osinfo_install_config_get_installation_url; osinfo_install_config_set_installation_url; + osinfo_tree_get_os_variants; } LIBOSINFO_1.4.0; /* Symbols in next release... diff --git a/osinfo/osinfo_tree.c b/osinfo/osinfo_tree.c index dd1cab2..8c1b321 100644 --- a/osinfo/osinfo_tree.c +++ b/osinfo/osinfo_tree.c @@ -916,7 +916,7 @@ void osinfo_tree_set_os(OsinfoTree *tree, OsinfoOs *os) } /** - * osinfo_tree_get_os_variant_list: + * osinfo_tree_get_os_variants: * @tree: an #OsinfoTree instance * * Gets the variants of the associated operating system. That last comment line above need tweaking too. I think libosinfo.syms also needs get_os and set_os to match, we export those for the media APIs as well With those fixed, series: Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> - Cole _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
