Re: [libosinfo PATCH 0/5] Remove osinfo-db related tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/20/19 11:12 AM, Fabiano Fidêncio wrote:
> This series removes the tests which either are part of osinfo-db or are
> going to be (as they've already been posted to the ML).
> 
> All the removed tests were testing only osinfo-db content. Now, with the
> addition the very same tests to osinfo-db, we can safely remove those
> here and never ever depend on adding new data on osinfo-db and test data
> here. :-)
> 
> The second patch is not going to be sent to the ML due to its size.
> Also, the whole amount of isodata files removed has been removed from
> the cover letter as it's just noise.
> 
> Fabiano Fidêncio (5):
>   tests: Remove test-*.uris
>   tests: Remove test-isodetect
>   test-os: Remove test_resources_minimum_recommended_maximum
>   test-os: Remove test_resources_uniqueness
>   test-os: Remove test_devices_duplication

Looks like by squashing in the isodata removal with the test-isodetect
change I can't review the code for that one. That said it's all just
removals so I'm sure it's fine

Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx>

- Cole

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux