Re: [osinfo-db PATCH 2/2] opensuse, autoyast: Fix typo in config's name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/18/19 3:46 PM, Fabiano Fidêncio wrote:
> 
> 
> On Mon, Feb 18, 2019 at 9:20 PM Cole Robinson <crobinso@xxxxxxxxxx
> <mailto:crobinso@xxxxxxxxxx>> wrote:
> 
>     On 2/18/19 4:40 AM, Fabiano Fidêncio wrote:
>     > We've been using "user-fullname" instead "user-realname" in different
>     > profiles for quite a long time.
>     >
>     > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx
>     <mailto:fidencio@xxxxxxxxxx>>
>     > ---
>     >  .../opensuse.org/opensuse-autoyast-desktop.xml.in
>     <http://opensuse.org/opensuse-autoyast-desktop.xml.in>             
>      | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
>     >
>     > diff --git
>     a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>     <http://opensuse.org/opensuse-autoyast-desktop.xml.in>
>     b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>     <http://opensuse.org/opensuse-autoyast-desktop.xml.in>
>     > index 00fc6af..a4e5b03 100644
>     > ---
>     a/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>     <http://opensuse.org/opensuse-autoyast-desktop.xml.in>
>     > +++
>     b/data/install-script/opensuse.org/opensuse-autoyast-desktop.xml.in
>     <http://opensuse.org/opensuse-autoyast-desktop.xml.in>
>     > @@ -18,7 +18,7 @@
>     > 
>     >        <!-- Account options -->
>     >        <param name="admin-password" policy="optional"/>
>     > -      <param name="user-fullname" policy="optional"/>
>     > +      <param name="user-realname" policy="optional"/>
>     >        <param name="user-login" policy="required"/>
>     >        <param name="user-password" policy="optional"/>
>     >        <param name="avatar-location" policy="optional"/>
>     >
> 
>     Isn't this missing an associated change later in the file?
> 
> 
> Indeed, do you want a v2 or can I do the change before pushing?
>  

Just fixing+pushing is fine by me?

Thanks,
Cole

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux