Re: [libosinfo PATCH 2/2] tests: abort() in case curl misbehaves

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 04, 2019 at 02:44:26PM +0100, Fabiano Fidêncio wrote:
> Although the issue with curl should be fixed by the previous commit,
> let's abort in case it misbehaves, avoiding then to have all the data
> printed on stdout.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
>  tests/test-imageuris.c | 9 +++++++++
>  tests/test-mediauris.c | 9 +++++++++
>  tests/test-treeuris.c  | 9 +++++++++
>  3 files changed, 27 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>


There's probably a case to be made for merging these three tests into
one test file as they duplicate 90% of each others code.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux