[snip] > > + if (profile == NULL) > > + return script; > > + > > Since 'NULL' is not a valid value, shouldn't this be > g_return_val_if_fail (profile != NULL, NULL); > ? Makes sense. I'll do this change and also adapt the test to *not* call osinfo_os_find_install_script() passing a NULL profile. _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo