Re: [libosinfo PATCH v4 08/10] loader: Load Images information

[Pino Toscano <ptoscano@xxxxxxxxxx>]

On Friday, 23 November 2018 11:54:42 CET Fabiano Fidêncio wrote:
> +static OsinfoImage *osinfo_loader_image(OsinfoLoader *loader,
> +                                        xmlXPathContextPtr ctxt,
> +                                        xmlNodePtr root,
> +                                        const gchar *id,
> +                                        GError **err)
> +{
> +    const OsinfoEntityKey keys[] = {
> +        { OSINFO_IMAGE_PROP_URL, G_TYPE_STRING },
> +        { NULL, G_TYPE_INVALID }
> +    };
> +
> +    gchar *arch = (gchar *)xmlGetProp(root, BAD_CAST "arch");
> +    gchar *format = (gchar *)xmlGetProp(root, BAD_CAST "format");

Should the various OSINFO_IMAGE_PROP_* defines be used here?

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo