On Wed, Nov 21, 2018 at 09:08:05AM +0000, Daniel P. Berrangé wrote: > On Wed, Nov 21, 2018 at 09:44:47AM +0100, Christophe Fergeau wrote: > > > -nodist_libosinfo_1_0_la_SOURCES = \ > > > +nodist_libosinfo_impl_la_SOURCES = \ > > > osinfo_enum_types.c \ > > > $(NULL) > > > > > > +lib_LTLIBRARIES = libosinfo-1.0.la > > > + > > > +libosinfo_1_0_la_SOURCES = > > > + > > > +libosinfo_1_0_la_LIBADD = libosinfo-impl.la > > > +libosinfo_1_0_la_LIBADD += $(libosinfo_impl_la_LIBADD) > > > + > > > +libosinfo_1_0_la_LDFLAGS = \ > > > + $(COVERAGE_LDFLAGS) \ > > > + $(VERSION_SCRIPT_FLAGS)$(LIBOSINFO_VERSION_FILE) \ > > > + -version-info $(LIBOSINFO_VERSION_INFO) \ > > > + $(NO_UNDEFINED_FLAGS) > > > + > > > +libosinfo_1_0_la_DEPENDENCIES = libosinfo.syms libosinfo-impl.la > > > > Here, I would expect libtool to be able to infer the libosinfo-impl.la > > dependency from 'libosinfo_1_0_la_LIBADD = libosinfo-impl.la' above > > IIRC there is a problem - if you specify _DEPENDENCIES = ... at all, > as needed for the libosinfo.syms file, then I believe it discards the > default dependancy on libosinfo-impl.la Ah right, we need EXTRA_..._DEPENDENCIES = libosinfo.syms https://www.gnu.org/software/automake/manual/automake.html#index-EXTRA_005fmaude_005fDEPENDENCIES-1 https://gitlab.freedesktop.org/spice/spice-gtk/commit/ed876b4cc Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
