Hey, On Tue, Nov 20, 2018 at 03:11:23PM +0100, Fabiano Fidêncio wrote: > Let's create libosinfo-impl.la which is nothing else than > libosinfo-1.0.la without stripping out its non-public symbols. > > libosinfo-impl.la can be used to link directly against our tests (as > those may use private functions that we do *not* want to expose), while > the "official" one (libosinfo-1.0.la) will remain the same. > > Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> > --- > -nodist_libosinfo_1_0_la_SOURCES = \ > +nodist_libosinfo_impl_la_SOURCES = \ > osinfo_enum_types.c \ > $(NULL) > > +lib_LTLIBRARIES = libosinfo-1.0.la > + > +libosinfo_1_0_la_SOURCES = > + > +libosinfo_1_0_la_LIBADD = libosinfo-impl.la > +libosinfo_1_0_la_LIBADD += $(libosinfo_impl_la_LIBADD) I don't think you need to append $(libosinfo_impl_la_LIBADD) to libosinfo_1_0_la_LIBADD, libtool should figure what it needs from libosinfo-impl.la which is already listed. Apart from this, looks good to me. Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
