On Fri, 2018-11-16 at 15:11 -0500, Cole Robinson wrote: > On 11/14/2018 06:25 AM, Fabiano Fidêncio wrote: > > This patch set introduces resources' inheritance for OSes that > > derive-from/clone a device that already has its resources set. > > > > While this patch doesn't cause any harm per si, we should wait at > > least > > 1 or 2 releases (after the one that includes this series) to start > > removing the duplicated entries from osinfo-db. > > > > This bit is interesting, maybe we should have a formal policy with > these > types of changes. Also aren't some apps accessing the XML directly? > They > will need to be notified about semantic breaking XML additions Indeed. Daniel, Pino, Both Nova and virt-builder-repository (and maybe more?) are consuming osinfo-db XMLs directly ... I'd really like to hear your suggestion on how we should proceed on this front. > > > - Changes since v1: > > > > https://www.redhat.com/archives/libosinfo/2018-November/msg00094.html > > - Changed the schema in order to explicitly indicate that the > > resources should be inherited > > - Addressed Pino's comments on using g_assert_true() instead of > > just > > g_assert() > > > > - osinfo-db: > > Fabiano Fidêncio (1): > > schema: Add 'inherit' attribute to resources element > > > > data/schema/osinfo.rng.in | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > - libosinfo: > > Fabiano Fidêncio (5): > > resources: Add osinfo_resources_{get,set}_inherit() > > loader: Set "inherit" accordingly to the resources > > os: Add _get_.*_resources_without_inheritance() > > os: Support inherited resources > > test-os: Add test_resources_inheritance() > > > > Reviewed-by: Cole Robinson <crobinso@xxxxxxxxxx> Series has been pushed, thanks! > > - Cole _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
