On Mon, Nov 19, 2018 at 01:26:43PM +0100, Fabiano Fidêncio wrote:
> On Mon, 2018-11-19 at 11:43 +0000, Daniel P. Berrangé wrote:
> > Make it possible to debug failures by displaying the URL,
> > curl error code/message and http code.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> > tests/test-mediauris.c | 4 ++++
> > tests/test-treeuris.c | 4 ++++
> > 2 files changed, 8 insertions(+)
> >
> > diff --git a/tests/test-mediauris.c b/tests/test-mediauris.c
> > index 443fdc3..c906f08 100644
> > --- a/tests/test-mediauris.c
> > +++ b/tests/test-mediauris.c
> > @@ -46,6 +46,10 @@ static void test_media(OsinfoMediaList *medialist,
> > GError **error, CURL *curl)
> > curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE,
> > &response_code);
> >
> > g_test_message("res=%d, %s; code=%ld", res,
> > curl_easy_strerror(res), response_code);
> > + if (res != CURLE_OK) {
> > + g_printerr("Failed URI %s res=%d (%s) code=%ld\n",
> > + url, res, curl_easy_strerror(res),
>
> We have a small problem on using g_printerr() though. It'll make the
> test to abort in the first failure it faces and it's not something we
> would like to do.
Err, no it doesn't. g_printerr() just prints to stderr, it never
aborts.
> > + }
> > g_assert_cmpint(res, ==, CURLE_OK);
> >
> > tmp = tmp->next;
>
> Would you be okay on changing the g_printerr() to g_test_message() or
> similar? If yes, please, just do the change and push the patch without
> the need of a v2.
g_test_message is invisible by default so I don't want to use that.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo
