Re: [libosinfo PATCH v2 1/2] test-os-resources: Fix typo in test_minimum_recommended_resources()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 13, 2018 at 12:34 PM Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
>
> Thanks to this typo the test was iterating over a single OS, always.
>
> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
>  tests/test-os-resources.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/test-os-resources.c b/tests/test-os-resources.c
> index fe16b72..a8a9018 100644
> --- a/tests/test-os-resources.c
> +++ b/tests/test-os-resources.c
> @@ -91,7 +91,7 @@ test_minimum_recommended_resources(void)
>      oses = osinfo_list_get_elements(OSINFO_LIST(oslist));
>
>      for (oses_it = oses; oses_it != NULL; oses_it = oses_it->next) {
> -        OsinfoOs *os = oses->data;
> +        OsinfoOs *os = oses_it->data;

Ops! Lgtm

Reviewed-by: Felipe Borges <feborges@xxxxxxxxxx>

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux