Re: [Patch] tests: continue after failure in mediauris & treeuris

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-11-08 at 20:51 +0100, Vera Cholasta wrote:
> ---
>  tests/test-mediauris.c | 1 +
>  tests/test-treeuris.c  | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/tests/test-mediauris.c b/tests/test-mediauris.c
> index c4fa356..443fdc3 100644
> --- a/tests/test-mediauris.c
> +++ b/tests/test-mediauris.c
> @@ -115,6 +115,7 @@ main(int argc, char *argv[])
>      int ret;
>  
>      g_test_init(&argc, &argv, NULL);
> +    g_test_set_nonfatal_assertions();
>  
>      g_test_add_func("/mediauris/uris", test_uris);
>  
> diff --git a/tests/test-treeuris.c b/tests/test-treeuris.c
> index b0b14e1..9b5c679 100644
> --- a/tests/test-treeuris.c
> +++ b/tests/test-treeuris.c
> @@ -115,6 +115,7 @@ main(int argc, char *argv[])
>      int ret;
>  
>      g_test_init(&argc, &argv, NULL);
> +    g_test_set_nonfatal_assertions();
>  
>      g_test_add_func("/treeuris/uris", test_uris);
>  


Reviewed-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>

I'll add the reference for the bugzilla we have for this in the commit
message before pushing and also close the bugzilla.

One thing that I'd like to hear from you Věra, is whether the messages
we currently have are good enough for people who are helping us to test
our project (like you!) or if they could've been improved somehow?

This is, for sure, not material for this patch, but I do believe a
cleaner message could be thrown in a way that we'd at least mention
which is the OS' short id where the failure happened.

Please, let me know your thoughts and we can open an issue for that in
our gitlab* (we've decided to start tracking stuff there ... an
announcement will be done soon).

*: https://gitlab.com/libosinfo/libosinfo/issues

Best Regards,
-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux