Felipe, Patch looks good (apart from a minor comment inline). I really would like to have the isodata from the RHEL ISOs added to the libosinfo but here I'm not sure whether you submitted those but they didn't arrive yet (have I told you that our ML has been weird Today? ;-)) or if you plan to submit those later. In any case, I'll merge this one after having the isodata for libosinfo. On Tue, Oct 30, 2018 at 10:19 PM Felipe Borges <felipe10borges@xxxxxxxxx> wrote: > > https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/7.6_release_notes/ > > Signed-off-by: Felipe Borges <feborges@xxxxxxxxxx> > --- > data/os/redhat.com/rhel-7.6.xml.in | 89 ++++++++++++++++++++++++++++++ > 1 file changed, 89 insertions(+) > create mode 100644 data/os/redhat.com/rhel-7.6.xml.in > > diff --git a/data/os/redhat.com/rhel-7.6.xml.in b/data/os/redhat.com/rhel-7.6.xml.in > new file mode 100644 > index 0000000..38fa766 > --- /dev/null > +++ b/data/os/redhat.com/rhel-7.6.xml.in > @@ -0,0 +1,89 @@ > +<libosinfo version="0.0.1"> > +<!-- Licensed under the GNU General Public License version 2 or later. > + See http://www.gnu.org/licenses/ for a copy of the license text --> > + <os id="http://redhat.com/rhel/7.6";> > + <short-id>rhel7.6</short-id> > + <_name>Red Hat Enterprise Linux 7.6</_name> > + <version>7.6</version> > + <_vendor>Red Hat, Inc</_vendor> > + <family>linux</family> > + <distro>rhel</distro> > + <codename>Maipo</codename> > + <upgrades id="http://redhat.com/rhel/7.5"/> > + <derives-from id="http://redhat.com/rhel/7.5"/> > + > + <release-date>2018-10-30</release-date> > + > + <media arch="x86_64"> > + <iso> > + <system-id>LINUX</system-id> > + <volume-id>.*RHEL-7.6.*x86_64.*</volume-id> > + </iso> > + <kernel>isolinux/vmlinuz</kernel> > + <initrd>isolinux/initrd.img</initrd> > + </media> > + > + <media arch="aarch64"> > + <iso> > + <system-id>LINUX</system-id> > + <volume-id>RHEL-7.6.*aarch64$</volume-id> > + </iso> > + </media> > + > + <media arch="ppc64"> > + <iso> > + <system-id>PPC</system-id> > + <volume-id>RHEL-7.6.*ppc64$</volume-id> > + </iso> > + </media> > + > + <media arch="ppc64le"> > + <iso> > + <system-id>PPC</system-id> > + <volume-id>RHEL-7.6.*ppc64le$</volume-id> > + </iso> > + </media> > + > + <media arch="s390x"> > + <iso> > + <system-id>LINUX</system-id> > + <volume-id>RHEL-7.6.*s390x$</volume-id> > + </iso> > + </media> > + > + <resources arch="ppc64"> > + <minimum> > + <n-cpus>1</n-cpus> > + <cpu>1000000000</cpu> > + <ram>2147483648</ram> > + <storage>10737418240</storage> > + </minimum> > + > + <recommended> > + <cpu>400000000</cpu> > + <ram>2147483648</ram> > + <storage>21474836480</storage> > + </recommended> > + </resources> > + > + <resources arch="all"> > + <minimum> > + <n-cpus>1</n-cpus> > + <cpu>1000000000</cpu> > + <ram>1073741824</ram> > + <storage>10737418240</storage> > + </minimum> > + > + <recommended> > + <cpu>1000000000</cpu> > + <ram>1073741824</ram> > + <storage>10737418240</storage> > + </recommended> > + </resources> Considering the resources are the same from 7.5, I'd prefer to not have them explicitly set here (and I can remove them before pushing if you agree). Basically, libosinfo inherits the resources values from the derived OS and, yes, we'll have to clean up the redundant info at some point /o\. > + > + <installer> > + <script id='http://redhat.com/rhel/kickstart/jeos'/> > + <script id='http://redhat.com/rhel/kickstart/desktop'/> > + </installer> > + </os> > +</libosinfo> > -- > 2.17.2 > > _______________________________________________ > Libosinfo mailing list > Libosinfo@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libosinfo Thanks a lot for the contribution! Best Regards, -- Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
