В Пт, 19/10/2018 в 08:28 +0200, Fabiano Fidêncio пишет: > On Thu, 2018-10-18 at 22:50 +0300, Alexey Shabalin wrote: > > Add isodata for ALT Linux 8.X, p8(snapshot of stable branch), and > > sisyphus(snapshot of devel branch) > > So, this time the patch applied without any issue (although we'd > prefer > having it inline instead of attached). > > Anyways, > > Let's go for the review: > - alt.p8.starterkits is not a valid short-id (that's what's used to > compare the ISOs). I've changed it to match with the short-id you > provided in the patches for osinfo-db: "alt.p8" > Ok. > - Running the tests I've noticed that our documentation should be > improved we don't mention anywhere that the "volume-size" entry is > supposed to be the "volume-size * block size" info from the media. I was use volume-size for separate live and install variant K- Workstation, because other isoinfo the same. I was send bug our release managers for modify policy naming for isoinfo. > I've > changed it everywhere needed. > > The patches (these ones + the ones for osinfo-db) are good to be > merged, but I'd hold on till: > > - Please, gimme your "I'm okay with your changes" related to the > volume-size (on osinfo-db) and to the dir name (the change to > "alt.p8" > here in this series); > I'm okay with your changes :) > - Please, where can I find the eol-date of the distros so I could > double-check your first series? And would be really good if we could > also have the eol date added for 1.0, 2.0 and 2.2. As I said when > reviewing the osinfo-db patches, please, feel free to just send a > link > that contains all the eol dates and I can do the changes for 1.0, 2.0 > and 2.2 and squash them into your patch (as long as you agree with > that). > I was resend PATCH1/3 with updated EOL dates for old distributives. This dates correct about 80%. I can't find more accurate info. https://www.altlinux.org/Branches (Russian only) http://ftp.altlinux.ru/pub/distributions/ALTLinux It's a pity, but latest file in branch directory is not EOL. > Thanks for the contribution, Alexey, really appreciated! Thank you. _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
