>>> On 10/3/2018 at 01:45 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > Charles. > > On Wed, Oct 3, 2018 at 9:21 PM Charles Arnold <carnold@xxxxxxxx> wrote: >> >> There have been three releases. >> >> Charles Arnold (3): >> Add SUSE CaaS Platform 1.0 isodata >> Add SUSE CaaS Platform 2.0 isodata >> Add SUSE CaaS Platform 3.0 isodata >> > > Those changes broke test-isodetect and it happened because the > directory which contains the isodata should match the short-id of the > OS. > So, for instance, instead of caasp10, it should be named caasp1.0. > > There's no need to submit a v2, I can do the changes manually before > pushing the patches (and I'll push those after your feedback on the > osinfo-db series). Thank you! > > A kind unrelated topic (but not so much) ... I've noticed that > openSUSE also keeps one downstream patch for a Windows volume id. > Would be possible for you to also send that upstream? That would make > our life easier wrt maintaining opensuse package. I will get that one ready and submit. Thanks for the review, - Charles > > And thanks for submitting those changes! > > Best Regards, > -- > Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
