Re: [PATCH 2/2] silverblue: Fix remote name typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 6, 2018 at 7:22 AM Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
> I've tested your patches and they do work with the following patch
> squashed to the this one:
> [fidencio@dahmer osinfo-db]$ git diff
> diff --git a/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> b/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> index aa5c035..83cdd57 100644
> --- a/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> +++ b/data/install-script/fedoraproject.org/silverblue-kickstart-desktop.xml.in
> @@ -96,7 +96,7 @@ AutomaticLogin=<xsl:value-of select="config/user-login"/>
>  [debug]
>  " > /etc/gdm/custom.conf
>
> -rm -f /etc/ostree/remotes.d/fedora-workstation.conf
> +rm -f /etc/ostree/remotes.d/fedora-'<xsl:value-of select="os/version"/>'.conf

Yes, good catch!

> Would you give me your ack to squash my patch into yours before pushing?

ack

> By the way, the way I tested was just by calling: `rpm-ostree upgrade`
> after an express installation with Boxes (and it works!). Is it
> enough?

Yeah, that's enough to verify that the URL is working (and I suspect it
did pull down an update, right?).

Thanks for testing this!

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux