Hey, this looks good to me, just a few small nits: On Wed, Jul 18, 2018 at 07:43:20AM +0200, Věra Cholasta wrote: > --- > data/os/alpinelinux.org/alpinelinux-3.8.xml.in | 50 ++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 data/os/alpinelinux.org/alpinelinux-3.8.xml.in > > diff --git a/data/os/alpinelinux.org/alpinelinux-3.8.xml.in b/data/os/alpinelinux.org/alpinelinux-3.8.xml.in > new file mode 100644 > index 0000000..4aaa321 > --- /dev/null > +++ b/data/os/alpinelinux.org/alpinelinux-3.8.xml.in > @@ -0,0 +1,50 @@ > +<?xml version="1.0" encoding="UTF-8"?> > +<libosinfo version="0.0.1"> > +<!-- Licensed under the GNU General Public License version 2 or later. > + See http://www.gnu.org/licenses/ for a copy of the license text --> > + <os id="http://alpinelinux.org/alpinelinux/3.8";> > + <short-id>alpinelinux3.8</short-id> > + <_name>Alpine Linux 3.8</_name> > + <version>3.8</version> > + <_vendor>Alpine Linux Project</_vendor> > + <family>linux</family> > + <distro>alpinelinux</distro> > + <upgrades id="http://alpinelinux.org/alpinelinux/3.7"/> > + <derives-from id="http://alpinelinux.org/alpinelinux/3.7"/> > + > + <resources arch="all"> > + <minimum> > + <cpu>1000000000</cpu> > + <n-cpus>1</n-cpus> > + <ram>134217728</ram> > + <storage>1073741824</storage> > + </minimum> > + <recommended> > + <cpu>1000000000</cpu> > + <n-cpus>1</n-cpus> > + <ram>805306368</ram> > + <storage>4294967296</storage> I'd remove the tabs at the beginning of the lines and replace them with spaces > + </recommended> > + </resources> > + <media arch="i686"> > + <iso> > + <volume-id>alpine-.* 3.8.\d x86$</volume-id> > + </iso> > + </media> > + <media arch="x86_64"> > + <iso> > + <volume-id>alpine-.* 3.8.\d x86_64.*</volume-id> Any reason for using .* here at the end of the regex? I guess it could be $ as for the others? > + </iso> > + </media> > + <media arch="ppc64le"> > + <iso> > + <volume-id>alpine-.* 3.8.\d ppc64le</volume-id> Ditto here, I guess it could be made consistent with the others with a $ (I did not test these suggestions against the testsuite though). I can make these adjustments before pushing, no need for a v2. Thanks for the patches, Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
