Re: [PATCH] syms: Fix identation of 0.2.13 symbols

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 7, 2018 at 8:10 AM, Michal Privoznik <mprivozn@xxxxxxxxxx> wrote:
> On 06/06/2018 10:14 PM, Fabiano Fidêncio wrote:
>> When adding the symbols for LIBOSINFO_0.2.13 I mistakenly added the
>> symbols not respecting default identation used (1 tab) and ended up
>> using 4 spaces instead.
>>
>> Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx>
>> ---
>>  osinfo/libosinfo.syms | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms
>> index aec2b1b..bde9cd9 100644
>> --- a/osinfo/libosinfo.syms
>> +++ b/osinfo/libosinfo.syms
>> @@ -521,8 +521,8 @@ LIBOSINFO_0.2.12 {
>>  } LIBOSINFO_0.2.11;
>>
>>  LIBOSINFO_0.2.13 {
>> -    global:
>> -    osinfo_media_get_eject_after_install;
>> +     global:
>> +     osinfo_media_get_eject_after_install;
>>  } LIBOSINFO_0.2.12;
>>
>>  LIBOSINFO_0.2.14 {
>>
>
> This patch does not apply cleanly for me.

Argh! It happens because I wrote this patch atop of
"network-installer" series. Let me redo it atop of master.

> Also I've noticed that some
> versions are missing "global:" label, e.g. LIBOSINFO_0.2.10.

I'll also fix this one when submitting v2.

>
> Michal


Thanks for the review!
-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux