On Mon, May 14, 2018 at 1:47 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Mon, May 14, 2018 at 01:20:43PM +0200, Fabiano Fidêncio wrote: >> On Mon, May 14, 2018 at 1:04 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: >> > On Sun, May 13, 2018 at 11:05:36AM +0200, Fabiano Fidêncio wrote: >> >> From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> >> >> >> >> For the user installing the system it does matter whether they will use >> >> the Live, Network Installer or Atomic version of Fedora Workstation >> >> (taking this as an example). So, let's expose this info instead of just >> >> showing "Fedora Workstation" for all of those. >> >> >> >> Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> >> >> --- >> >> data/os/fedoraproject.org/fedora-27.xml.in | 10 +++++----- >> >> data/os/fedoraproject.org/fedora-28.xml.in | 10 +++++----- >> >> 2 files changed, 10 insertions(+), 10 deletions(-) >> >> >> >> diff --git a/data/os/fedoraproject.org/fedora-27.xml.in b/data/os/fedoraproject.org/fedora-27.xml.in >> >> index ba657d0..a48728d 100644 >> >> --- a/data/os/fedoraproject.org/fedora-27.xml.in >> >> +++ b/data/os/fedoraproject.org/fedora-27.xml.in >> >> @@ -14,19 +14,19 @@ >> >> <release-date>2017-11-14</release-date> >> >> >> >> <variant id="workstation"> >> >> - <_name>Fedora 27 Workstation</_name> >> >> + <_name>Fedora 27 Workstation (Live)</_name> >> > >> > This is redundant with live="true" on the <media> nodes, and actually >> > gnome-boxes is already appending "(Live)" on its own when this attribute >> > is set, so I'm not sure this is the right way to go. >> >> Makes sense. >> Does the patch still make sense with this part dropped? > > While (Atomic) is harder to express in a generic way, I feel that the > "Network Installer" bit might be useful as some kind of XML attribute > rather than being in the string? Okay, so I'll re-work this patch with your suggestion in mind and keep it out of the release I'm preparing for Today. Thanks for the review, Christophe! > > Christophe > >> >> > >> > Christophe >> > >> >> </variant> >> >> <variant id="workstation-netinst"> >> >> - <_name>Fedora 27 Workstation</_name> >> >> + <_name>Fedora 27 Workstation (Network Installer)</_name> >> >> </variant> >> >> <variant id="workstation-atomic"> >> >> - <_name>Fedora 27 Workstation</_name> >> >> + <_name>Fedora 27 Workstation (Atomic)</_name> >> >> </variant> >> >> <variant id="server"> >> >> - <_name>Fedora 27 Server</_name> >> >> + <_name>Fedora 27 Server (DVD)</_name> >> >> </variant> >> >> <variant id="server-netinst"> >> >> - <_name>Fedora 27 Server</_name> >> >> + <_name>Fedora 27 Server (Network Installer)</_name> >> >> </variant> >> >> >> >> <!-- Workstation --> >> >> diff --git a/data/os/fedoraproject.org/fedora-28.xml.in b/data/os/fedoraproject.org/fedora-28.xml.in >> >> index cda279c..4e75d63 100644 >> >> --- a/data/os/fedoraproject.org/fedora-28.xml.in >> >> +++ b/data/os/fedoraproject.org/fedora-28.xml.in >> >> @@ -14,19 +14,19 @@ >> >> <release-date>2018-05-01</release-date> >> >> >> >> <variant id="workstation"> >> >> - <_name>Fedora 28 Workstation</_name> >> >> + <_name>Fedora 28 Workstation (Live)</_name> >> >> </variant> >> >> <variant id="workstation-netinst"> >> >> - <_name>Fedora 28 Workstation</_name> >> >> + <_name>Fedora 28 Workstation (Network Installer)</_name> >> >> </variant> >> >> <variant id="workstation-atomic"> >> >> - <_name>Fedora 28 Workstation</_name> >> >> + <_name>Fedora 28 Workstation (Atomic)</_name> >> >> </variant> >> >> <variant id="server"> >> >> - <_name>Fedora 28 Server</_name> >> >> + <_name>Fedora 28 Server (DVD)</_name> >> >> </variant> >> >> <variant id="server-netinst"> >> >> - <_name>Fedora 28 Server</_name> >> >> + <_name>Fedora 28 Server (Network Installer)</_name> >> >> </variant> >> >> >> >> <!-- Workstation --> >> >> -- >> >> 2.14.3 >> >> >> >> _______________________________________________ >> >> Libosinfo mailing list >> >> Libosinfo@xxxxxxxxxx >> >> https://www.redhat.com/mailman/listinfo/libosinfo >> > >> > _______________________________________________ >> > Libosinfo mailing list >> > Libosinfo@xxxxxxxxxx >> > https://www.redhat.com/mailman/listinfo/libosinfo >> > >> >> >> >> -- >> Fabiano Fidêncio -- Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
