On Sat, May 12, 2018 at 1:34 PM, Pierre-Alain TORET <pierre-alain.toret@xxxxxxxxxxxxxx> wrote: > Le 12/05/2018 à 12:30, Fabiano Fidêncio a écrit : >> On Tue, May 8, 2018 at 9:47 PM, Pierre-Alain TORET >> <pierre-alain.toret@xxxxxxxxxxxxxx> wrote: >>> Signed-off-by: Pierre-Alain TORET <pierre-alain.toret@xxxxxxxxxxxxxx> >>> --- >>> data/os/netbsd.org/netbsd-7.1.2.xml.in | 64 ++++++++++++++++++++++++++ >>> 1 file changed, 64 insertions(+) >>> create mode 100644 data/os/netbsd.org/netbsd-7.1.2.xml.in >>> >>> diff --git a/data/os/netbsd.org/netbsd-7.1.2.xml.in >>> b/data/os/netbsd.org/netbsd-7.1.2.xml.in >>> new file mode 100644 >>> index 0000000..e045e88 >>> --- /dev/null >>> +++ b/data/os/netbsd.org/netbsd-7.1.2.xml.in >>> @@ -0,0 +1,64 @@ >>> +<libosinfo version="0.0.1"> >>> + >>> + <os id="http://netbsd.org/netbsd/7.1.2"> >>> + <short-id>netbsd7.1.2</short-id> >>> + <_name>NetBSD 7.1.2</_name> >>> + <version>7.1.2</version> >>> + <_vendor>NetBSD Project</_vendor> >>> + <family>netbsd</family> >>> + <distro>netbsd</distro> >>> + <upgrades id="http://netbsd.org/netbsd/7.1"/> >>> + <derives-from id="http://netbsd.org/netbsd/7.1"/> >> >> It derives-from and upgrades 7.1.1 (not 7.1) >> I've fixed this locally before pushing. >> >>> + >>> + <release-date>2018-03-15</release-date> >>> + >>> + <media arch="x86_64"> >>> + >>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-amd64.iso</url> >> >> I'm not sure why there's the new line for the URL, but it causes >> errors applying the patch. >> I've fixed this locally before pushing. >> >>> + <iso> >>> + <system-id>NetBSD</system-id> >>> + <volume-id>NETBSD_712</volume-id> >>> + <volume-size>393832448</volume-size> >>> + </iso> >>> + </media> >>> + <media arch="x86_64"> >>> + >>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot.iso</url> >> >> Same here. >> >>> + <iso> >>> + <system-id>NetBSD</system-id> >>> + <volume-id>NETBSD_712</volume-id> >>> + <volume-size>86235136</volume-size> >>> + </iso> >>> + </media> >>> + <media arch="x86_64"> >>> + >>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/amd64/installation/cdrom/boot-com.iso</url> >> >> Same here. >> >>> + <iso> >>> + <system-id>NetBSD</system-id> >>> + <volume-id>NETBSD_712</volume-id> >>> + <volume-size>86235136</volume-size> >>> + </iso> >>> + </media> >>> + <media arch="i686"> >>> + >>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/images/NetBSD-7.1.2-i386.iso</url> >> >> Same here. >> >>> + <iso> >>> + <system-id>NetBSD</system-id> >>> + <volume-id>NETBSD_712</volume-id> >>> + <volume-size>427264000</volume-size> >>> + </iso> >>> + </media> >>> + <media arch="i686"> >>> + >>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot.iso</url> >> >> Same here. >> >>> + <iso> >>> + <system-id>NetBSD</system-id> >>> + <volume-id>NETBSD_712</volume-id> >>> + <volume-size>91035648</volume-size> >>> + </iso> >>> + </media> >>> + <media arch="i686"> >>> + >>> <url>https://cdn.netbsd.org/pub/NetBSD/NetBSD-7.1.2/i386/installation/cdrom/boot-com.iso</url> >> >> Same here. >> >>> + <iso> >>> + <system-id>NetBSD</system-id> >>> + <volume-id>NETBSD_712</volume-id> >>> + <volume-size>91035648</volume-size> >>> + </iso> >>> + </media> >>> + </os> >>> +</libosinfo> >>> -- >>> 2.17.0 >>> >>> >>> _______________________________________________ >>> Libosinfo mailing list >>> Libosinfo@xxxxxxxxxx >>> https://www.redhat.com/mailman/listinfo/libosinfo >> >> >> I'll push your patches, with the modifications, later Today. >> Thanks for your contribution! >> > > Hello Fabiano, > > thank you for taking the time to fix my patch. No problem. :-) I've also noticed (and fixed locally): - Volume size didn't match with the ones provided in the libosinfo patch; - There was no isodata for the NetBSD-7.1.2-amd64.iso I've fixed both, squashed my fixes into yours and Tomorrow I'll do a release including the patches! Again, thanks a lot for the contribution! > > Regards, > > > _______________________________________________ > Libosinfo mailing list > Libosinfo@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libosinfo -- Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo