I've addressed the misc comments in that email, and pushed the series, thanks! Christophe On Wed, Jan 10, 2018 at 11:44:08AM +0100, Christophe Fergeau wrote: > Hey, > > On Tue, Jan 09, 2018 at 02:09:35PM +0700, Vincent Dao wrote: > > From: Vincent <vincent.dao@xxxxxxxxxxx> > > > > Signed-off-by: Vincent <vincent.dao@xxxxxxxxxxx> > > --- > > data/os/asianux.com/asianux-4.6.xml.in | 50 ++++++++++++++++++++++++++++++ > > data/os/asianux.com/asianux-4.7.xml.in | 50 ++++++++++++++++++++++++++++++ > > data/os/asianux.com/asianux-7.0.xml.in | 44 ++++++++++++++++++++++++++ > > data/os/asianux.com/asianux-7.1.xml.in | 45 +++++++++++++++++++++++++++ > > data/os/asianux.com/asianux-7.2.xml.in | 45 +++++++++++++++++++++++++++ > > data/os/asianux.com/asianux-unknown.xml.in | 42 +++++++++++++++++++++++++ > > 6 files changed, 276 insertions(+) > > create mode 100644 data/os/asianux.com/asianux-4.6.xml.in > > create mode 100644 data/os/asianux.com/asianux-4.7.xml.in > > create mode 100644 data/os/asianux.com/asianux-7.0.xml.in > > create mode 100644 data/os/asianux.com/asianux-7.1.xml.in > > create mode 100644 data/os/asianux.com/asianux-7.2.xml.in > > create mode 100644 data/os/asianux.com/asianux-unknown.xml.in > > > > diff --git a/data/os/asianux.com/asianux-4.6.xml.in b/data/os/asianux.com/asianux-4.6.xml.in > > new file mode 100644 > > index 0000000..f0215ac > > --- /dev/null > > +++ b/data/os/asianux.com/asianux-4.6.xml.in > > @@ -0,0 +1,50 @@ > > +<?xml version="1.0" encoding="UTF-8"?> > > +<libosinfo version="0.0.1"> > > + > > + <os id="http://asianux.com/asianux/4.6";> > > + <short-id>asianux4.6</short-id> > > + <name>Asianux Server 4 SP6</name> > > + <vendor>Asianux Project</vendor> > > + <family>linux</family> > > + <distro>asianux</distro> > > + <codename>Hiranya</codename> > > + > > + <release-date>2016-07-21</release-date> > > + > > + <media arch="x86_64"> > > + <iso> > > + <system-id>LINUX</system-id> > > + <volume-id>Asianux Server 4 SP6 x86_64</volume-id> > > + </iso> > > + <kernel>isolinux/vmlinuz</kernel> > > + <initrd>isolinux/initrd.img</initrd> > > + </media> > > + > > + <media arch="i686"> > > + <iso> > > + <system-id>LINUX</system-id> > > + <volume-id>Asianux Server 4 SP6 i686</volume-id> > > + </iso> > > + <kernel>isolinux/vmlinuz</kernel> > > + <initrd>isolinux/initrd.img</initrd> > > + </media> > > + > > + <resources arch="all"> > > + <minimum> > > + <n-cpus>1</n-cpus> > > + <ram>536870912</ram> > > + </minimum> > > + > > + <recommended> > > + <cpu>400000000</cpu> > > + <ram>1073741824</ram> > > + <storage>9663676416</storage> > > + </recommended> > > + </resources> > > + > > + <installer> > > + <script id='http://redhat.com/rhel/kickstart/jeos'/> > > + <script id='http://redhat.com/rhel/kickstart/desktop'/> > > + </installer> > > + </os> > > +</libosinfo> > > \ No newline at end of file > > diff --git a/data/os/asianux.com/asianux-4.7.xml.in b/data/os/asianux.com/asianux-4.7.xml.in > > new file mode 100644 > > index 0000000..719a1b2 > > --- /dev/null > > +++ b/data/os/asianux.com/asianux-4.7.xml.in > > @@ -0,0 +1,50 @@ > > +<?xml version="1.0" encoding="UTF-8"?> > > +<libosinfo version="0.0.1"> > > + > > + <os id="http://asianux.com/asianux/4.7";> > > + <short-id>asianux4.7</short-id> > > + <name>Asianux Server 4 SP7</name> > > + <vendor>Asianux Project</vendor> > > + <family>linux</family> > > + <distro>asianux</distro> > > + <codename>Hiranya</codename> > > > > No <upgrades id="http://asianux.com/asianux/4.6"/> ? (and same for the > other 4.x versions). > > > > diff --git a/data/os/asianux.com/asianux-7.0.xml.in b/data/os/asianux.com/asianux-7.0.xml.in > > new file mode 100644 > > index 0000000..815074b > > --- /dev/null > > +++ b/data/os/asianux.com/asianux-7.0.xml.in > > @@ -0,0 +1,44 @@ > > +<?xml version="1.0" encoding="UTF-8"?> > > +<libosinfo version="0.0.1"> > > + > > + <os id="http://asianux.com/asianux/7.0";> > > + <short-id>asianux7.0</short-id> > > + <name>Asianux Server 7</name> > > + <version>7.0</version> > > + <vendor>Asianux Project</vendor> > > + <family>linux</family> > > + <distro>asianux</distro> > > + <codename>Lotus</codename> > > I don't know if it's there's an upgrade path from 4.x to 7.0? > Apparently asianux.com is derived from RHEL? (same versioning, same > kickstart files, ...) If yes, you could add a > <derives-from id="http://redhat.com/rhel/7.0"/> tag. > > > + > > + <release-date>2015-07-16</release-date> > > + > > + <media arch="x86_64"> > > + <iso> > > + <system-id>LINUX</system-id> > > + <volume-id>Asianux Server 7.0 x86_64</volume-id> > > + </iso> > > + <kernel>isolinux/vmlinuz</kernel> > > + <initrd>isolinux/initrd.img</initrd> > > + </media> > > + > > + <resources arch="all"> > > + <minimum> > > + <n-cpus>1</n-cpus> > > + <cpu>1000000000</cpu> > > + <ram>1073741824</ram> > > + <storage>10737418240</storage> > > + </minimum> > > + > > + <recommended> > > + <cpu>400000000</cpu> > > + <ram>1073741824</ram> > > + <storage>9663676416</storage> > > + </recommended> > > The recommended storage (9GB) is less than the minimum storage (10GB), > this should be bigger (same issue with the other 7.x versions). > > Apart from these small comments, this looks good, thanks, > > Christophe > _______________________________________________ > Libosinfo mailing list > Libosinfo@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libosinfo
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
