Hi Christophe, On Thu, Nov 16, 2017 at 10:16 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > Hey, > > On Sun, Nov 12, 2017 at 05:04:19PM +0100, Zeeshan Ali wrote: >> Use of 'const' parameter on object parameters is redundant, inconsistent >> (both internally and against other GObject libraries) and currently breaks >> the low-level Rust binding generator: >> >> https://github.com/gtk-rs/glib/pull/249 > > Could the Rust binding generator be fixed to cope with that instead? I'm actually hoping for both to happen. :) > It's definitely not used consistently, but removing a 'const' from > external API is going to cause breakage in C++ code: Well that's true but IMHO this breakage is OK, given: * the unlikelyhood of an existing C++ project using libosinfo. * how trivial the fix is to this breakage. But that's just my opinion. :) P.S. Kudos for writing the actual code to test this. _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo