Re: [PATCH libosinfo v2] test-isodetect: add Debian's arm flavours

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 13, 2017 at 02:39:47PM +0200, Guido Günther wrote:
> to avoid "Unknown arch" debug messages
> ---
>  tests/test-isodetect.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/test-isodetect.c b/tests/test-isodetect.c
> index c72b8fc..9306be4 100644
> --- a/tests/test-isodetect.c
> +++ b/tests/test-isodetect.c
> @@ -128,8 +128,14 @@ static struct ISOInfo *load_iso(GFile *file, const gchar *shortid, const gchar *
>          arch = "ia64";
>      else if (strstr(name, "s390x"))
>          arch = "s390x";
> -    else if (strstr(name, "aarch64"))
> +    else if (strstr(name, "aarch64") ||
> +             strstr(name, "arm64"))
>          arch = "aarch64";
> +    else if (strstr(name, "armv7l"))
> +        arch = "armv7l";
> +    else if (strstr(name, "armhf") ||
> +             strstr(name, "armv7hl"))
> +        arch = "armv7hl";

These should all just be normalizing to 'armv7l' - ie arm7 little endian. No
need for a hard vs soft float distinction here, that's just a CPU sub-feature
not a different architecture.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux