On Wed, May 3, 2017 at 10:25 AM, Pino Toscano <ptoscano@xxxxxxxxxx> wrote: > On Tuesday, 2 May 2017 23:25:21 CEST Fabiano Fidêncio wrote: >> Pino, >> >> >> On Tue, Apr 18, 2017 at 12:36 PM, Pino Toscano <ptoscano@xxxxxxxxxx> wrote: >> > --- >> > .../ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt | 29 ++++++++++++++++++++++ >> > .../ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt | 29 ++++++++++++++++++++++ >> > .../ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt | 29 ++++++++++++++++++++++ >> > .../ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt | 29 ++++++++++++++++++++++ >> > .../ubuntu17.04/ubuntu-17.04-server-i386.iso.txt | 29 ++++++++++++++++++++++ >> > .../ubuntu-17.04-server-ppc64el.iso.txt | 17 +++++++++++++ >> > .../ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt | 29 ++++++++++++++++++++++ >> > 7 files changed, 191 insertions(+) >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-amd64.iso.txt >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-desktop-i386.iso.txt >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-amd64.iso.txt >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-arm64.iso.txt >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-i386.iso.txt >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-ppc64el.iso.txt >> > create mode 100644 test/isodata/ubuntu/ubuntu17.04/ubuntu-17.04-server-s390x.iso.txt >> >> I'm facing some make check issues related to >> "ubuntu-17.04-desktop-amd64.iso.txt" (would you mind checking whether >> you can see the same issue on your system?) >> >> You'll have to move these files under tests dir instead of test due to >> the changes done in the commit a409a71b2c5 > > If I move the data according to the recent test -> tests renaming, they > seem to be working here. I'll refresh this patch so it can be tested > cleanly. Hmm. Testing against a fresh osinfo-db build imported in the system, for some reason, makes the test-isodetect fail with: Running suite(s): List 78%: Checks: 14, Failures: 3, Errors: 0 test-isodetect.c:354:F:Core:test_rhel:0: ISO RHEL-6.9-20170309.0-Server-x86_64-dvd1.iso.txt was not matched by OS rhel6.9 test-isodetect.c:354:F:Core:test_ubuntu:0: ISO ubuntu-17.04-desktop-amd64.iso.txt was not matched by OS ubuntu17.04 test-isodetect.c:354:F:Core:test_centos:0: ISO CentOS-6.8-x86_64-netinstall.iso.txt was not matched by OS centos6.8 FAIL test-isodetect (exit status: 1) The test passes when setting OSINFO_SYSTEM_DIR to my osinfo-db/data folder though. Anyways, I'm acking and pushing these 2 patches. -- Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
