On Tue, May 02, 2017 at 07:48:52PM +0400, Roman Bogorodskiy wrote: > Daniel P. Berrange wrote: > > > On Tue, May 02, 2017 at 07:22:47PM +0400, Roman Bogorodskiy wrote: > > > Christophe Fergeau wrote: > > > > > > > > > > > Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> > > > > and pushed. > > > > > > Oops, it looks like it should be moved to 'tests' dir now (I generated > > > this patch before the rename). > > > > I'll sort that. > > Thanks! > > > > Also, I've noticed that trailing whitespaces were stripped: > > > > > > https://gitlab.com/libosinfo/libosinfo/commit/093d9cb73e40065d44656c53cff73d780589d686 > > > > > > Is that something some sort of post-processing that needs to be done > > > after running 'isoinfo -d -i'? Quick glance over isoinfo manpage does > > > not show how to make it strip whitespaces. > > > > I stripped whitespace, otherwise "syntax-check" fails - I think we've > > always just done it manually. > > Oh, weird, syntax-check doesn't fail for me (luckily, I still have a > branch with that commit as I sent it and before test -> tests). Maybe > yet another GNU and BSD grep (or whatever tool is used to find this) > incompatibilities. :-( Oh, actually, I see what happened - cfg.mk tells syntax-check to ignore all trailing whitespace on tests/isodata. So the only reason we hit the build failure was because we committed them in the wrong directory first. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
