Re: [PATCH osinfo-db] Use SOURCE_DATE_EPOCH to make build reproducible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 22, 2017 at 11:47 AM, Chris Lamb <lamby@xxxxxxxxxx> wrote:
> using a fixed timestamp when the variable is set
> ---
>  Makefile | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 48d2951..1846f7a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,7 +1,11 @@
>
>  VPATH = .
>
> -TODAY = $(shell date +"%Y%m%d")
> +ifdef SOURCE_DATE_EPOCH
> +    TODAY = $(shell date --utc --date="@$(SOURCE_DATE_EPOCH)" +"%Y%m%d")
> +else
> +    TODAY = $(shell date +"%Y%m%d")
> +endif
>
>  OSINFO_DB_EXPORT = osinfo-db-export
>  OSINFO_DB_IMPORT = osinfo-db-import
> --
> 2.11.0
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libosinfo

Chris,

Thanks for the patch. Would you mind adding some notes to the README
just to make as explicit as possible that someone who may be
interested can generate a build from a specific date using
SOURCE_DATE_EPOCH env var (and an example on how to do so)?

Best Regards,
-- 
Fabiano Fidêncio

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux