On Thu, Apr 13, 2017 at 01:26:00PM +0200, Fabiano Fidêncio wrote: > On Thu, Apr 13, 2017 at 11:48 AM, Daniel P. Berrange > <berrange@xxxxxxxxxx> wrote: > > On Wed, Apr 12, 2017 at 11:05:47PM +0200, Zeeshan Ali (Khattak) wrote: > >> Hi Fabiano, > >> > >> On 12 April 2017 at 11:09, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > >> > If media is an installer, thus specifies whether the media should be > >> > persistent accross the final reboot during its installation process. > >> > Default value is false. > >> > >> Thanks for looking into this. I'd prefer a more obvious/specific name, > >> e.g 'eject-after-install' or something along that line. > > > > We'd have to make that default to 'true' if missing from the XML too, to > > avoid changing semantics for existing XML which lacks this attribute. > > Hmm. Here I'm not sure because we still do not support any SLES > express-installation. So, is it really necessary to set the default to > "true" even if it's just going to be used for the not-yet added SLES > installation scripts? If you have a corresponding method gboolean osinfo_media_get_eject_after_install() we want that to return true for all existing media which do not have this new 'eject-after-install' attribute set in their XML Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
