Re: [osinfo-db PATCH v3] Sort list of sources in POTFILES.in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 21, 2017 at 4:59 PM, Pino Toscano <ptoscano@xxxxxxxxxx> wrote:
> This way, the generation of osinfo-db.pot is more deterministic and
> stable, and it is way easier to diff pot files before and after editing
> the XML definitions of OSes, devices, etc.
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index a7a5c68..48d2951 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -81,7 +81,7 @@ clean:
>         rm -f $(DATA_FILES) $(SCHEMA_FILES) po/POTFILES.in po/osinfo-db.pot
>
>  po/POTFILES.in:
> -       $(V_GEN) find data -name *.xml.in > $@
> +       $(V_GEN) find data -name *.xml.in | LC_ALL=C sort > $@
>
>  po/osinfo-db.pot: po/POTFILES.in $(DATA_FILES_IN)
>         $(V_GEN) cd po && $(INTLTOOL_UPDATE) --gettext-package $(GETTEXT_PACKAGE) --pot
> --
> 2.9.3

Seems that all comments raised by Eric have been addressed.
The patch looks fine by me and I'll push it later Today.

Best Regards.

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux