On Tuesday, 21 March 2017 16:04:47 CET Eric Blake wrote: > On 03/21/2017 05:13 AM, Pino Toscano wrote: > > This way, the generation of osinfo-db.pot is more deterministic and > > stable, and it is way easier to diff pot files before and after editing > > the XML definitions of OSes, devices, etc. > > --- > > Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Makefile b/Makefile > > index a7a5c68..56ed3a8 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -81,7 +81,7 @@ clean: > > rm -f $(DATA_FILES) $(SCHEMA_FILES) po/POTFILES.in po/osinfo-db.pot > > > > po/POTFILES.in: > > - $(V_GEN) find data -name *.xml.in > $@ > > + $(V_GEN) find data -name *.xml.in | env LC_ALL=C sort > $@ > > Why the use of 'env'? I don't see what it is adding here. Got used to 'env' in case there are various environment variables to pass, since in some contexts (which I cannot remember anymore) doing `VAR1=val VAR2=val command ...` was not working. I will drop it, and send v3. Thanks, -- Pino Toscano
Attachment:
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
