Daniel P. Berrange wrote:
> On Wed, Feb 08, 2017 at 07:50:10PM +0400, Roman Bogorodskiy wrote:
> > Do not hardcode '/usr/bin/perl' because on FreeBSD and maybe some other
> > systems it's installed in a different prefix, so use '/usr/bin/env perl'
> > instead.
> > ---
> > osinfo/check-symsorting.pl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/osinfo/check-symsorting.pl b/osinfo/check-symsorting.pl
> > index 470247c..cc7b8d6 100755
> > --- a/osinfo/check-symsorting.pl
> > +++ b/osinfo/check-symsorting.pl
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/perl
> > +#!/usr/bin/env perl
> >
> > # Copyright (C) 2012-2013 Red Hat, Inc.
> > #
>
> Does this matter ? the Makefile.am rule is using $(PERL) to pick the
> right emulator to run iiuc
Yeah, it looks like that, but it still fails:
$ gmake check V=1
Making check in osinfo
gmake[1]: Entering directory '/usr/home/novel/code/libosinfo/osinfo'
gmake check-am
gmake[2]: Entering directory '/usr/home/novel/code/libosinfo/osinfo'
gmake check-local
gmake[3]: Entering directory '/usr/home/novel/code/libosinfo/osinfo'
./check-symsorting.pl \
. ./libosinfo.syms
gmake[3]: ./check-symsorting.pl: Command not found
gmake[3]: *** [Makefile:1386: check-symsorting] Error 127
gmake[3]: Leaving directory '/usr/home/novel/code/libosinfo/osinfo'
gmake[2]: *** [Makefile:1220: check-am] Error 2
gmake[2]: Leaving directory '/usr/home/novel/code/libosinfo/osinfo'
gmake[1]: *** [Makefile:1222: check] Error 2
gmake[1]: Leaving directory '/usr/home/novel/code/libosinfo/osinfo'
gmake: *** [Makefile:594: check-recursive] Error 1
And there's no PERL defined in Makefile, only INTLTOOL_PERL. Not sure
what bit should define PERL, after a brief look I didn't find that.
Roman Bogorodskiy
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
