On Mon, Jan 16, 2017 at 5:57 PM, Debarshi Ray <rishi.is@xxxxxxxxx> wrote: > On Mon, Jan 16, 2017 at 04:28:52PM +0000, Debarshi Ray wrote: >> On Thu, Jan 12, 2017 at 12:26:31AM +0100, Fabiano Fid??ncio wrote: >> > +if [ -n <xsl:value-of select="config/reg-login"/> -a -n <xsl:value-of select="config/reg-password"/> ]; then >> >> We need to enclose the strings in quotes because [ -n -a -n ] will >> evaluate to TRUE. Try these: >> $ if [ -n ]; then echo foo; fi >> foo >> $ if [ -n "" ]; then echo foo; fi >> $ > > For reference: > http://tldp.org/LDP/abs/html/comparison-ops.html Thanks for the review. I sent a v2 of this patch and fixed this very same issue in a few other places (other 2 different patches). -- Fabiano Fidêncio _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
