On Tue, Jul 5, 2016 at 6:14 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > On Tue, Jul 5, 2016 at 4:04 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: >> Ping, would love a review on this series, as its a pre-requisite >> for being able to split off the OS database. > > Sure, I'll do it as the first thing Tomorrow. Daniel, series look good. There is one typo in patch 3 (but it came from c&p) and a few really minor comments in patch 4 (so, feel free to ignore them or do the changes before pushing the patches). Best Regards. > >> >> On Tue, Jun 28, 2016 at 04:52:26PM +0100, Daniel P. Berrange wrote: >>> This series contains a bunch of small-ish patches doing >>> random fixes and enhancements to the osinfo-db-tools >>> package >>> >>> Notable things >>> >>> - Fix osinfo-db-validate to look for RNG schema in the >>> database tree location >>> - Add a new osinfo-db-path tool >>> - Improve the way we create tar.xz packages >>> >>> Daniel P. Berrange (11): >>> Share code for getting database path locations >>> Fix description of import/export commands >>> Add a new osinfo-db-path tool for reporting db locations >>> Find RNG schema in default database locations >>> Change osinfo-db-validate to default to a standard location >>> Set a valid error domain for GError >>> Remove print of filenames when --verbose is not used >>> Fix swapped file/directory permissions in tar file >>> Explicitly set timestamps on entries in created tar file >>> Filter list of files included in created tar >>> Fix source link in the RPM spec >>> >>> .gitignore | 3 + >>> mingw-osinfo-db-tools.spec.in | 2 + >>> osinfo-db-tools.spec.in | 4 +- >>> po/POTFILES.in | 2 + >>> tools/Makefile.am | 20 +++- >>> tools/osinfo-db-export.c | 107 +++++--------------- >>> tools/osinfo-db-import.c | 84 +--------------- >>> tools/osinfo-db-path.c | 223 ++++++++++++++++++++++++++++++++++++++++++ >>> tools/osinfo-db-util.c | 164 +++++++++++++++++++++++++++++++ >>> tools/osinfo-db-util.h | 58 +++++++++++ >>> tools/osinfo-db-validate.c | 189 ++++++++++++++++++++++++++++------- >>> 11 files changed, 653 insertions(+), 203 deletions(-) >>> create mode 100644 tools/osinfo-db-path.c >>> create mode 100644 tools/osinfo-db-util.c >>> create mode 100644 tools/osinfo-db-util.h >>> >>> -- >>> 2.7.4 >>> >> >> Regards, >> Daniel >> -- >> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| >> |: http://libvirt.org -o- http://virt-manager.org :| >> |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| >> |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| >> >> _______________________________________________ >> Libosinfo mailing list >> Libosinfo@xxxxxxxxxx >> https://www.redhat.com/mailman/listinfo/libosinfo _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
