Hi, On Wed, May 11, 2016 at 5:37 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: > On Wed, May 11, 2016 at 6:26 PM, Zeeshan Ali (Khattak) > <zeeshanak@xxxxxxxxx> wrote: >> Hi, >> >> On Mon, May 9, 2016 at 1:43 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >>> Zeeshan, >>> >>> On Mon, May 9, 2016 at 12:59 PM, Zeeshan Ali (Khattak) >>> <zeeshanak@xxxxxxxxx> wrote: >>>> Hi Fabiano, >>>> >>>> On Fri, May 6, 2016 at 11:00 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: >>>>> On Thu, May 5, 2016 at 9:10 PM, Zeeshan Ali (Khattak) >>>>> <zeeshanak@xxxxxxxxx> wrote: >>>>>> --- >>>>>> data/os/microsoft.com/win-7.xml.in | 8 ++++---- >>>>>> data/os/microsoft.com/win-xp.xml.in | 8 ++++---- >>>>>> 2 files changed, 8 insertions(+), 8 deletions(-) >>>>>> >>>>>> diff --git a/data/os/microsoft.com/win-7.xml.in b/data/os/microsoft.com/win-7.xml.in >>>>>> index 2cb6488..8da4ccb 100644 >>>>>> --- a/data/os/microsoft.com/win-7.xml.in >>>>>> +++ b/data/os/microsoft.com/win-7.xml.in >>>>>> @@ -205,8 +205,8 @@ >>>>>> >>>>>> <!-- All virtio and QXL device drivers, and spice-vdagent --> >>>>>> <driver arch="i686" location="https://zeenix.fedorapeople.org/drivers/win-tools/postinst"; signed="false"> >>>>>> - <file>spice-guest-tools-0.65.exe</file> >>>>>> - <file>spice-guest-tools-0.65.cmd</file> >>>>>> + <file>spice-guest-tools-0.100.exe</file> >>>>>> + <file>spice-guest-tools-0.100.cmd</file> >>>>>> <file>redhat09.cer</file> >>>>>> <file>redhat10.cer</file> >>>>> >>>>> I've noticed that these certificate files are not used anymore with >>>>> the spice-guest-tools-0.100. So, is there any reason for keeping those >>>>> files here? >>>> >>>> I was not aware of that. I was under the impression that they are >>>> required by Windows. >>> >>> According to https://zeenix.fedorapeople.org/drivers/win-tools/postinst/spice-guest-tools-0.74.cmd >>> they are. >>> But then you removed the files for the 0.100.cmd file and that's the >>> reason I thought they are not needed anymore. >>> So, most likely they are still needed and those lines got removed >>> mistakenly, is it? >> >> Removed where? I have not removed any files. > > Please, take a look on the link that I pointed out, Zeeshan. > Here is the content of spice-guest-tools-0.74.cmd: Ah you meant to write "removed the files FROM the 0.100.cmd file". Sorry, I'm not that smart so you have to be very literal. :) > certutil -addstore "TrustedPublisher" redhat09.cer > certutil -addstore "TrustedPublisher" redhat10.cer > spice-guest-tools-0.74.exe /S > certutil -delstore "TrustedPublisher" "Red Hat, Inc." > > EXIT > > And here is the content of spice-guest-tools-0.100.cmd: > > spice-guest-tools-0.100.exe /S > EXIT > > Seems that you removed those lines while copying and pasting the .cmd > file's content. More like copying the wrong cmd file I found on my home directory and did not even bother to check the content of the previous version. :( >>> How did you test the 0.100.cmd file? >> >> I have not, yet, no. > > Please, test it before submitting the patch then or at least make > clear that you submitted something not test at all. ;-\ Fair enough. :) -- Regards, Zeeshan Ali (Khattak) _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
