Re: [PATCH v3 02/10] win10: Generalize "Education" vol ID expression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 9, 2016 at 6:03 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote:
> Let's generalize the x86 vol IDs expression in order to cover more
> volume IDs, based on the ones already covered in the x86_64 volume ID
> expression.

Sorry to be so pedantic but i can't help it. :) Would be nice to be
consistent here with terms

* volume, not vol (it's fine in shortlog for brevity)
* "ID expression" vs "IDs expression". I prefer the former.

Feel free to quickly fix those before pushing.

> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx>
> ---
>  data/os/microsoft.com/win-10.xml.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/data/os/microsoft.com/win-10.xml.in b/data/os/microsoft.com/win-10.xml.in
> index 980898d..23fbea3 100644
> --- a/data/os/microsoft.com/win-10.xml.in
> +++ b/data/os/microsoft.com/win-10.xml.in
> @@ -22,7 +22,7 @@
>      <media arch="i686">
>        <variant id="education"/>
>        <iso>
> -        <volume-id>J_CEDA_X86FRE_</volume-id>
> +        <volume-id>J_CEDN?A_X86FRE_</volume-id>
>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language";>[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>        </iso>
> @@ -30,7 +30,7 @@
>      <media arch="x86_64">
>        <variant id="education"/>
>        <iso>
> -        <volume-id>J_CEDNA_X64FRE_</volume-id>
> +        <volume-id>J_CEDN?A_X64FRE_</volume-id>
>          <publisher-id>MICROSOFT CORPORATION</publisher-id>
>          <l10n-language regex="true" l10n-language-map="http://microsoft.com/win/8/l10n-language";>[[:upper:][:digit:]_]*_([[:upper:]]*-[[:upper:]]*)</l10n-language>
>        </iso>
> --
> 2.7.4
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libosinfo



-- 
Regards,

Zeeshan Ali (Khattak)

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux