On Tue, May 3, 2016 at 4:09 PM, Zeeshan Ali (Khattak) <zeeshanak@xxxxxxxxx> wrote: > On Tue, May 3, 2016 at 2:57 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: >> On Tue, May 3, 2016 at 3:45 PM, Zeeshan Ali (Khattak) >> <zeeshanak@xxxxxxxxx> wrote: >>> On Tue, May 3, 2016 at 2:12 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: >>>> On Tue, May 3, 2016 at 2:50 PM, Zeeshan Ali (Khattak) >>>> <zeeshanak@xxxxxxxxx> wrote: >>>>> On Mon, May 2, 2016 at 10:53 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >>>>>> On Mon, May 2, 2016 at 11:33 PM, Zeeshan Ali (Khattak) >>>>>> <zeeshanak@xxxxxxxxx> wrote: >>>>>>> Hi, >>>>>>> >>>>>>> Cmd file mainly installs spice-guest-tools and that doesn't work for >>>>>>> windows >= 8. As you already mentioned, the avatar doesn't get >>>>>>> installed correctly either so I'm wondering about the usefulness of >>>>>>> this patch, as is. >>>>>> >>>>>> Well, at first I thought the avatar was not working because of this >>>>>> missing line and I had to include it, test it and then realize it's >>>>>> not working for any other reason that we don't know yet. >>>>>> So, I don't know, but IMO is better to have everything set as it is >>>>>> expected for a working unattended-installation (it could have saved me >>>>>> some time), mainly because it doesn't cause any harm. >>>>> >>>>> I don't understand the part after "IMO". If the script doesn't do what >>>>> it's supposed to, why do we want to include it? Why not just add it >>>>> commented out with a comment saying why it's not included? >>>> >>>> Well, even if the user avatar doesn't work, installing the >>>> drivers/guest tools should, no? >>> >>> What? I thought we established that spice-guest-tools does not work >>> for Windows >= 8. >> >> IIRC you don't try to install only the spice-guest-tools. You also >> install the virtio drivers, no? > > Those drivers are installed by spice-guest-tools. cmd itself does not > install any drivers AFAIK. > >> Have you checked if they got installed properly? They should, at least. > > IIRC spice-guest-tools first tries to install virtio drivers and then > QXL so I thought it might be successful in installing the former > before it fails on latter. I could not find any evidence of any > drivers installed at least. See the screenshot attached. It's from 8.1 > but I'm sure the same applies to 8 as well. As discussed on #boxes, it is an restriction that was set in some old version of spice-guest-tools. Updating spice-guest-tools to the latest one )0,100) we could benefit of the virtio drivers/agent, even if QXL doesn't work there. > >>> >>>> So, considering it does, removing the whole cmd file because the >>>> avatar doesn't work simply doesn't make sense for me. >>>> >>>>> >>>>>>> >>>>>>> On Sun, May 1, 2016 at 10:57 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: >>>>>>>> From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> >>>>>>>> >>>>>>>> Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> >>>>>>>> --- >>>>>>>> data/os/microsoft.com/win-8.xml.in | 1 + >>>>>>>> 1 file changed, 1 insertion(+) >>>>>>>> >>>>>>>> diff --git a/data/os/microsoft.com/win-8.xml.in b/data/os/microsoft.com/win-8.xml.in >>>>>>>> index d20b239..50a1a31 100644 >>>>>>>> --- a/data/os/microsoft.com/win-8.xml.in >>>>>>>> +++ b/data/os/microsoft.com/win-8.xml.in >>>>>>>> @@ -54,6 +54,7 @@ >>>>>>>> <installer> >>>>>>>> <script id='http://microsoft.com/windows/unattend/jeos'/> >>>>>>>> <script id='http://microsoft.com/windows/unattend/desktop'/> >>>>>>>> + <script id='http://microsoft.com/windows/cmd/desktop'/> >>>>>>>> </installer> >>>>>>>> </os> >>>>>>>> </libosinfo> >>>>>>>> -- >>>>>>>> 2.7.3 >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Libosinfo mailing list >>>>>>>> Libosinfo@xxxxxxxxxx >>>>>>>> https://www.redhat.com/mailman/listinfo/libosinfo >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> >>>>>>> Zeeshan Ali (Khattak) >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Libosinfo mailing list >>>>>>> Libosinfo@xxxxxxxxxx >>>>>>> https://www.redhat.com/mailman/listinfo/libosinfo >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Fabiano Fidêncio >>>>> >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> >>>>> Zeeshan Ali (Khattak) >>> >>> >>> >>> -- >>> Regards, >>> >>> Zeeshan Ali (Khattak) > > > > -- > Regards, > > Zeeshan Ali (Khattak) _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
